[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652899#comment-16652899
]
Ted Yu commented on HBASE-21246:
--------------------------------
bq. the strange thing is that we have a method which creates WALIdentity
directly from a String.
Good point.
In ReplicationSourceManager, we can change:
{code}
private final ConcurrentMap<String, Map<String, NavigableSet<String>>>
walsByIdRecoveredQueues;
{code}
to:
{code}
private final ConcurrentMap<String, Map<String, NavigableSet<WALIdentity>>>
walsByIdRecoveredQueues;
{code}
This way, in refreshSources(), we retrieve WALIdentity from the Map and don't
need to create identity.
I will drop createWALIdentity in the next patch.
> Introduce WALIdentity interface
> -------------------------------
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Fix For: HBASE-20952
>
> Attachments: 21246.003.patch, 21246.HBASE-20952.001.patch,
> 21246.HBASE-20952.002.patch, 21246.HBASE-20952.004.patch,
> 21246.HBASE-20952.005.patch
>
>
> We are introducing WALIdentity interface so that the WAL representation can
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent
> filename in distributed filesystem environment or, the name of the stream
> when the WAL is backed by log stream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
