[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659626#comment-16659626
]
Josh Elser commented on HBASE-21246:
------------------------------------
{quote}Waiting for more review.
{quote}
I don't think there's enough here to give a meaningful review to.
I can't find it now (only looked quickly), but you may recall that Stack's
stated concern about using a WALIdentity was having {{NoSuchLogException}} (or
similar) littered all over the place. How do we create/use readers and writers?
Where are we passing around {{WALIdentity}}'s and is this a major concern? I'd
expect some example of how the major codepaths that use WALs to be stubbed out
to show how they'd work with these changes you're proposing (even if they are
not functional at runtime).
One more concrete thing:
{code:java}
+ public FSWALIdentity(String name) {
+ this.path = new Path(name);
+ this.name = path.getName();
+ }{code}
Why do we have a {{String}} constructor anyways? We would always have a Path
when working with HDFS< no? Do the other providers need to give their own
implementation of WALIdentity?
> Introduce WALIdentity interface
> -------------------------------
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Fix For: HBASE-20952
>
> Attachments: 21246.003.patch, 21246.HBASE-20952.001.patch,
> 21246.HBASE-20952.002.patch, 21246.HBASE-20952.004.patch,
> 21246.HBASE-20952.005.patch, 21246.HBASE-20952.007.patch,
> 21246.HBASE-20952.008.patch
>
>
> We are introducing WALIdentity interface so that the WAL representation can
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent
> filename in distributed filesystem environment or, the name of the stream
> when the WAL is backed by log stream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
