[ 
https://issues.apache.org/jira/browse/HBASE-21215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662886#comment-16662886
 ] 

Sean Busbey commented on HBASE-21215:
-------------------------------------

{code}
  # Look for the --jar=/path/to/HBCK2.jar parameter. Else pass through to hbck.
485       case "${1}" in
486         --jar=*)
487         # Found --jar parameter. Add it to CLASSPATH and set CLASS to HBCK2.
488         JAR="${1#*=}"
489         if [ ! -f "${JAR}" ]; then
490           echo "${JAR} file not found!"
491           echo "Usage: hbase [<options>] hbck --jar=/path/to/HBCK2.jar 
[<args>]"
492           exit 1
493         fi
{code}

because we use an argument handling of the form {{--foo=bar}} instead of 
{{--foo bar}}, we don't get shell expansion of the argument for things like 
{{~}}. e.g.
{code}
hbase-3.0.0-SNAPSHOT busbey$ ./bin/hbase hbck 
--jar=~/.m2/repository/org/apache/hbase/hbase-hbck2/1.0.0-SNAPSHOT/hbase-hbck2-1.0.0-SNAPSHOT.jar
 
~/.m2/repository/org/apache/hbase/hbase-hbck2/1.0.0-SNAPSHOT/hbase-hbck2-1.0.0-SNAPSHOT.jar
 file not found!
Usage: hbase [<options>] hbck --jar=/path/to/HBCK2.jar [<args>]
{code}

probably a nit? the help does imply an absolute path. folks might find it 
confusing though.

> Figure how to invoke hbck2; make it easy to find
> ------------------------------------------------
>
>                 Key: HBASE-21215
>                 URL: https://issues.apache.org/jira/browse/HBASE-21215
>             Project: HBase
>          Issue Type: Sub-task
>          Components: amv2, hbck2
>            Reporter: stack
>            Assignee: stack
>            Priority: Major
>             Fix For: 2.1.1
>
>         Attachments: HBASE-21215.branch-2.1.001.patch, 
> HBASE-21215.branch-2.1.002.patch
>
>
> In 
> https://docs.google.com/document/d/1Oun4G3M5fyrM0OxXcCKYF8td0KD7gJQjnU9Ad-2t-uk/edit#,
>  the doc on hbck2 'form', one item to figure is how to invoke hbck2. Related, 
> how to make it easy to find? [~busbey] has some ideas (posted in doc). This 
> issue is for implementation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to