[ 
https://issues.apache.org/jira/browse/HBASE-21215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663150#comment-16663150
 ] 

Sean Busbey commented on HBASE-21215:
-------------------------------------

{code}
484       # Look for the -j /path/to/HBCK2.jar parameter. Else pass through to 
hbck.
485       case "${1}" in
486         -j*)
487         # Found -j parameter. Add arg to CLASSPATH and set CLASS to HBCK2.
488         shift
{code}

this should be
{code}
484       # Look for the -j /path/to/HBCK2.jar parameter. Else pass through to 
hbck.
485       case "${1}" in
486         -j)
487         # Found -j parameter. Add arg to CLASSPATH and set CLASS to HBCK2.
488         shift
{code}

specifically it's "-j)" instead of "-j*)"

otherwise you cover all possible options that start with "j' like
{code}
hbase-3.0.0-SNAPSHOT busbey$ ./bin/hbase hbck -jimminy-crickets 
~/.m2/repository/org/apache/hbase/hbase-hbck2/1.0.0-SNAPSHOT/hbase-hbck2-1.0.0-SNAPSHOT.jar
 
usage: HBCK2 [OPTIONS] COMMAND <ARGS>

Options:
 -d,--debug                                 run with debug output
...
{code}

with that corrected I'm +1

> Figure how to invoke hbck2; make it easy to find
> ------------------------------------------------
>
>                 Key: HBASE-21215
>                 URL: https://issues.apache.org/jira/browse/HBASE-21215
>             Project: HBase
>          Issue Type: Sub-task
>          Components: amv2, hbck2
>            Reporter: stack
>            Assignee: stack
>            Priority: Major
>             Fix For: 2.1.1
>
>         Attachments: HBASE-21215.branch-2.1.001.patch, 
> HBASE-21215.branch-2.1.002.patch, HBASE-21215.branch-2.1.003.patch, 
> HBASE-21215.branch-2.1.004.patch, HBASE-21215.branch-2.1.005.patch
>
>
> In 
> https://docs.google.com/document/d/1Oun4G3M5fyrM0OxXcCKYF8td0KD7gJQjnU9Ad-2t-uk/edit#,
>  the doc on hbck2 'form', one item to figure is how to invoke hbck2. Related, 
> how to make it easy to find? [~busbey] has some ideas (posted in doc). This 
> issue is for implementation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to