[
https://issues.apache.org/jira/browse/HBASE-5526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224069#comment-13224069
]
jirapos...@reviews.apache.org commented on HBASE-5526:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4217/#review5681
-----------------------------------------------------------
Looks good.
Some unnecessary reformating and some whitespace issues.
Also see minor comments inside.
Should probably give the motivation for the change (i.e. allow some users to
browse the HBase directory hierarchy, but not see the contents of any HFile or
HLog files.)
src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java
<https://reviews.apache.org/r/4217/#comment12385>
Is this a left-over from an older patch?
I don't see how FSUTils.create* could know which KEY to use to read the
perms from.
src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
<https://reviews.apache.org/r/4217/#comment12383>
Is "conf" different from "c" here? Should it?
(Maybe I am not grokking this part)
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<https://reviews.apache.org/r/4217/#comment12384>
left-over from an older patch?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<https://reviews.apache.org/r/4217/#comment12387>
Instead of using the static methods, would it be possible to instantiate a
FSUtils object per region (or maybe even region server) and configure that
instance with a Configuration?
Might make it worse... Just checking.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<https://reviews.apache.org/r/4217/#comment12386>
unnecessary reformat
src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java
<https://reviews.apache.org/r/4217/#comment12388>
pigurationaram? Is that an animal? :)
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
<https://reviews.apache.org/r/4217/#comment12389>
Unrelated layout changes.
src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
<https://reviews.apache.org/r/4217/#comment12390>
Ugh... I guess there is no way around this.
src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
<https://reviews.apache.org/r/4217/#comment12391>
Just gone?
src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
<https://reviews.apache.org/r/4217/#comment12392>
Unrelated
- Lars
On 2012-03-07 06:54:11, Jesse Yates wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4217/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-07 06:54:11)
bq.
bq.
bq. Review request for hbase and Lars Hofhansl.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add support for a configurable umask all files and directories created on
the dfs (as opposed to pids or logs).
bq.
bq.
bq. This addresses bug HBASE-5526.
bq. https://issues.apache.org/jira/browse/HBASE-5526
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/HConstants.java e60ce04
bq. src/main/java/org/apache/hadoop/hbase/io/Reference.java 6360059
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java
9e7e624
bq. src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java
c726603
bq. src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
8a7da2e
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 76ff422
bq. src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java
3f42efa
bq. src/main/java/org/apache/hadoop/hbase/regionserver/Store.java d884598
bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
12ebc0a
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java b5049b1
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
5c8fc5e
bq. src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
62cf6ac
bq. src/main/java/org/apache/hadoop/hbase/util/FSUtils.java d2d7efe
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 720841c
bq. src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java f6d088f
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/ZKSplitLog.java 30d7fe9
bq. src/main/resources/hbase-default.xml 9277e0c
bq.
src/test/java/org/apache/hadoop/hbase/TestFSTableDescriptorForceCreation.java
6bc7c32
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
a5628b9
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
5b3b962
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
f1ea701
bq. src/test/java/org/apache/hadoop/hbase/util/TestFSTableDescriptors.java
0db4d42
bq. src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java e2611e6
bq.
bq. Diff: https://reviews.apache.org/r/4217/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. "mvn clean test -P localTests" passes
bq.
bq.
bq. Thanks,
bq.
bq. Jesse
bq.
bq.
> Configurable file and directory based umask
> -------------------------------------------
>
> Key: HBASE-5526
> URL: https://issues.apache.org/jira/browse/HBASE-5526
> Project: HBase
> Issue Type: New Feature
> Components: regionserver
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.94.0
>
> Attachments: java_HBASE-5526-v2.patch, java_HBASE-5526.patch
>
>
> Currently many all the files created by the HBase user are just written using
> the default file permissions granted by hdfs. However, to ensure only the
> correct user/group views the files and directories, we need to be able to
> apply a configurable umask to either directories or files.
> This ticket covers setting permissions for files written to dfs, as opposed
> to things like pid and log files.
> The impetus for this was to allow the web-user to view the directory
> structure of hbase, but not to actually see any of the actual data hbase is
> storing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
