[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670832#comment-16670832
]
Josh Elser commented on HBASE-21415:
------------------------------------
Talked through this with Phil today in Slack.
Best as I can see, we synchronized on the MasterSnapshotManager methods,
through which all snapshot-creation requests flow. My hunch is that this
javadoc is from days-of-old, but didn't dig back into history to confirm.
Added Phil as a contributor and assigned this issue to him to track the
recognition. Thanks again!
> Admin#snapshot method documentation is misleading.
> --------------------------------------------------
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
> Reporter: Philippe Laflamme
> Assignee: Philippe Laflamme
> Priority: Trivial
> Attachments: HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
