[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671935#comment-16671935
]
Josh Elser commented on HBASE-21415:
------------------------------------
{quote}Canceling patch to update with a new one. Not sure if this is how I
should do this though...
{quote}
[~plaflamme], in general what we suggest is to just include a "number" in your
patch name and then upload a new one when required.
e.g. your first patch might be HBASE-21415.001.patch, your second
HBASE-21415.002.patch.
We like seeing the evolution of patches (helps to see context during longer
reviews) and you can just leave the "state" as Patch-Available (QA will see the
new file you attached and try to test it).
> Admin#snapshot method documentation is misleading.
> --------------------------------------------------
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
> Reporter: Philippe Laflamme
> Assignee: Philippe Laflamme
> Priority: Trivial
> Attachments: HBASE-21415.patch, HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
