[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679918#comment-16679918
]
Josh Elser commented on HBASE-21246:
------------------------------------
bq. Can we file a sub task for refactoring WALFactory, let's start from
fundamental classes, not a big one compared to this IMO.
SGTM.
bq. Back to the WALIdentity, i think the interface looks good to me, not
further comments about the introduction.
Thanks for taking a look, Reid!
Let me take a look at the last stream of patches (i'm not sure where we stand
presently), and see if we can get something committed today to the feature
branch as a starting point.
> Introduce WALIdentity interface
> -------------------------------
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Fix For: HBASE-20952
>
> Attachments: 21246.003.patch, 21246.20.txt, 21246.21.txt,
> 21246.23.txt, 21246.24.txt, 21246.25.txt, 21246.HBASE-20952.001.patch,
> 21246.HBASE-20952.002.patch, 21246.HBASE-20952.004.patch,
> 21246.HBASE-20952.005.patch, 21246.HBASE-20952.007.patch,
> 21246.HBASE-20952.008.patch, replication-src-creates-wal-reader.jpg,
> wal-factory-providers.png, wal-providers.png, wal-splitter-reader.jpg,
> wal-splitter-writer.jpg
>
>
> We are introducing WALIdentity interface so that the WAL representation can
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent
> filename in distributed filesystem environment or, the name of the stream
> when the WAL is backed by log stream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
