[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715410#comment-16715410
]
Ankit Singhal commented on HBASE-21246:
---------------------------------------
Thanks [~elserj] for the review.
{quote}I see RecoveredReplicationSource.java still needs some "unraveling" from
Path.
WALEntryStream is in a similar position (a couple of others than just those
pulled out above).
{quote}
We may not need to change these Path to WalIdentity once these classes are
refactored to abstract FS based implementation. The code related to path is
expected to be moved in FS based implementation.
{quote} Should DisabledWALProvider have its own implementation of WALIdentity?
Looks like we just pass a "special" Path in the FS-based case now – maybe we
just make some special implementation of WALIdentity for it instead.{quote}
Let me introduce the new WALIdentity for it.
{quote}As long as we can spin out the above refactorings into some follow-on
work, I would be happy to land this on the feature branch.{quote}
Yes, these refactorings goes in another follow-on jira, let me just upload a
another patch fixing the checkstyle and the test failure before you commit.
> Introduce WALIdentity interface
> -------------------------------
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Fix For: HBASE-20952
>
> Attachments: 21246.003.patch, 21246.20.txt, 21246.21.txt,
> 21246.23.txt, 21246.24.txt, 21246.25.txt, 21246.26.txt, 21246.34.txt,
> 21246.37.txt, 21246.39.txt, 21246.41.txt, 21246.43.txt,
> 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch,
> 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch,
> 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch,
> HBASE-21246.master.001.patch, replication-src-creates-wal-reader.jpg,
> wal-factory-providers.png, wal-providers.png, wal-splitter-reader.jpg,
> wal-splitter-writer.jpg
>
>
> We are introducing WALIdentity interface so that the WAL representation can
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent
> filename in distributed filesystem environment or, the name of the stream
> when the WAL is backed by log stream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
