[
https://issues.apache.org/jira/browse/HBASE-21647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742751#comment-16742751
]
stack commented on HBASE-21647:
-------------------------------
How often you think getChildrenLatchWithoutLocking method will be called? Once
per draw of the UI? Or more often than this? If former that won't be much? I'm
surprised the non-synchronized access didn't trigger findbugs complaint. Its
read of an int. Probably better to synchronize and then later if a perf issue,
we can deal.
On state, I see. The actual 'state' is overwritten by what comes next? Thats an
interesting issue. I think you need to add note to this effect otherwise its
confusing. Add it around currentRunningState or probably better, to the
updateState method itself (Doest his method have to be public? Can it be
package private at least?). What we have here is a special case for SCP. I
could see us moving to make a general soln for all Procedures at a later state
if call for it (if I understand properly what is going on here).
Thanks.
> Add status track for splitting WAL tasks
> ----------------------------------------
>
> Key: HBASE-21647
> URL: https://issues.apache.org/jira/browse/HBASE-21647
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jingyun Tian
> Assignee: Jingyun Tian
> Priority: Major
> Attachments: HBASE-21647.master.001.patch,
> HBASE-21647.master.002.patch, Screenshot from 2019-01-03 15-31-26.png,
> Screenshot from 2019-01-03 15-31-36.png
>
>
> add status track to help operator check the status of splitting WAL
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
