[
https://issues.apache.org/jira/browse/HBASE-21843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761688#comment-16761688
]
Wellington Chevreuil commented on HBASE-21843:
----------------------------------------------
I meant if changing AbstractFSWALProvider.isMetaFile() "if" statement to
"p.indexOf(META_WAL_PROVIDER_ID) >=0" instead of
"p.endsWith(META_WAL_PROVIDER_ID)" would be less risky, then changing current
file naming logic. But I guess that naming convention was already wrong, so if
we are sure it's not impacting, definitely makes more sense.
Patch looks good to me, [~Apache9], [~stack], I guess we could get to a good
understanding on what caused the problem, can try the same steps again with the
fix just to make sure.
> RegionGroupingProvider breaks the meta wal file name pattern which may cause
> data loss for meta region
> ------------------------------------------------------------------------------------------------------
>
> Key: HBASE-21843
> URL: https://issues.apache.org/jira/browse/HBASE-21843
> Project: HBase
> Issue Type: Bug
> Components: wal
> Affects Versions: 3.0.0, 2.1.0, 2.2.0
> Reporter: Wellington Chevreuil
> Assignee: Wellington Chevreuil
> Priority: Blocker
> Labels: data-loss
> Fix For: 3.0.0, 2.2.0, 2.1.3, 2.0.5, 2.3.0
>
> Attachments: HBASE-21843.master.001.patch, HBASE-21843.patch
>
>
> A bit unusual, but managed to face this twice lately on both distributed and
> local standalone mode, on VMs. Somehow, after some VM pause/resume, got into
> a situation where regions on meta were assigned to a give RS startcode that
> had no corresponding WAL dir.
> That caused those regions to never get assigned, because the given RS
> startcode is not found anywhere by RegionServerTracker/ServerManager, so no
> SCP is created to this RS startcode, leaving the region "open" on a dead
> server forever, in META.
> Could get this sorted by adding extra check on loadMeta, checking if the RS
> assigned to the region in meta is not online and doesn't have a WAL dir, then
> mark this region as offline.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
