[
https://issues.apache.org/jira/browse/HBASE-21763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773058#comment-16773058
]
Wellington Chevreuil commented on HBASE-21763:
----------------------------------------------
Hi [~arshiya9414], validations are looking great now. Some minor writing
suggestions for the error messages:
1) For the port validation error message, we need a white space in the sentence
before "Please...". Also a final point in the sentence. Here's a suggestion:
{noformat}
usage(options, "Invalid client port. Please provide proper port for target
hbase ensemble.");
{noformat}
2) For the znode validation error, same sentence "cosmetics" as above, but
maybe also worth that a "/' is needed at the beginning, to make clear what
might be missing. Below a suggestion:
{noformat}
usage(options, "Invalid parent znode. Please provide proper parent znode for
target hbase. Note that valid znodes must start with \"/\".");
{noformat}
For the added test, can we verify "-v" writes the correct version? The test can
read it from the properties file than check if output contains the same string.
Right now it's only validating that -v option will not return an error, but if
someone inadvertently changes readHBCK2BuildProperties() method in away it
doesn't read the properties file properly, but does not throw any error, this
test will still pass.
> [HBCK2] hbck2 options does not work and throws exceptions
> ---------------------------------------------------------
>
> Key: HBASE-21763
> URL: https://issues.apache.org/jira/browse/HBASE-21763
> Project: HBase
> Issue Type: Bug
> Components: hbck2
> Affects Versions: hbck2-1.0.0
> Reporter: Syeda Arshiya Tabreen
> Assignee: Syeda Arshiya Tabreen
> Priority: Minor
> Fix For: hbck2-1.0.0
>
> Attachments: HBASE-21763.001.patch, HBASE-21763.patch
>
>
> HBCK2 options throws below exceptions when executed
> 1. *--version* option throws NullPointerException
> 2. *--hbase.zookeeper.property.clientPort* option throws NumberFormatException
> 3. *--zookeeper.znode.parent* option throws IllegalArgumentException
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
