[
https://issues.apache.org/jira/browse/HBASE-21763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785869#comment-16785869
]
Wellington Chevreuil commented on HBASE-21763:
----------------------------------------------
Thanks for the heads up, [~arshiya9414]! Tests looking good. Just some minor
suggestions:
1) For *testVersionOption* is to actually use
_assertEquals(expectedVersionOutput, actualVersionOutput)__,_ instead of
_assertTrue_ currently used. That way, _assertEquals_ will already print a
meaningful error message if it fails, showing what was expected and what was
returned, and there's no need for the *System.out.println* after the check.
2) For *testHelp,* we might not need the extra *System.out.println* after the
_assertTrue_ check, as it will already print the output contents if the
validation fails.
> [HBCK2] hbck2 options does not work and throws exceptions
> ---------------------------------------------------------
>
> Key: HBASE-21763
> URL: https://issues.apache.org/jira/browse/HBASE-21763
> Project: HBase
> Issue Type: Bug
> Components: hbck2
> Affects Versions: hbck2-1.0.0
> Reporter: Syeda Arshiya Tabreen
> Assignee: Syeda Arshiya Tabreen
> Priority: Minor
> Fix For: hbck2-1.0.0
>
> Attachments: HBASE-21763.001.patch, HBASE-21763.002.patch,
> HBASE-21763.patch
>
>
> HBCK2 options throws below exceptions when executed
> 1. *--version* option throws NullPointerException
> 2. *--hbase.zookeeper.property.clientPort* option throws NumberFormatException
> 3. *--zookeeper.znode.parent* option throws IllegalArgumentException
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
