[
https://issues.apache.org/jira/browse/HBASE-21999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786985#comment-16786985
]
Sean Busbey commented on HBASE-21999:
-------------------------------------
here's an example addendum
* fail the build when the saveVersion script exits, rather than skipping the
creation of Version.java and waiting for a later failure
* make the name of the build step easier to pick out in the maven output
* don't fail on VCS command failure
* WARN on VCS command failure and use the existing "unknown" that we'd use if
no VCS
alternatively, I could make things fail when we're in a release build since
that's when we care about having this kind of revision info. wdyt?
> [DEBUG] Exit if git returns empty revision!
> -------------------------------------------
>
> Key: HBASE-21999
> URL: https://issues.apache.org/jira/browse/HBASE-21999
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: stack
> Priority: Major
> Fix For: 3.0.0, 2.0.5, 2.1.4, 2.2.1
>
> Attachments: HBASE-21999-addendum-v0.patch
>
>
> Let me commit a bit of debug on branch-2.0. Can't figure out how we are
> getting empty git revision string. Have the build fail if empty....
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
