[
https://issues.apache.org/jira/browse/HBASE-21895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794081#comment-16794081
]
Duo Zhang commented on HBASE-21895:
-----------------------------------
{quote}
<!-- All -Xep need to be on single line see:
https://github.com/google/error-prone/pull/1115 -->
{quote}
Good, this is exactly what I missed before. After upgrading to the new error
prone version, it keeps telling me unknown compiler flags...
And the compile is also failed? Now we enable error prone by default after the
patch?
Thanks.
> Take more care on the error prone plugin and warnings
> -----------------------------------------------------
>
> Key: HBASE-21895
> URL: https://issues.apache.org/jira/browse/HBASE-21895
> Project: HBase
> Issue Type: Umbrella
> Reporter: Duo Zhang
> Priority: Major
> Attachments: HBASE-21895.master.001.patch
>
>
> As shown in HBASE-21890 , the error prone warnings are truly useful.
> But now, the javac warnings section in the pre commit result is messed up, it
> always reports unrelated warnings. Need to take a look at it.
> And also, we should try out best to clean up the warnings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
