[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800892#comment-16800892
]
Sean Busbey commented on HBASE-22100:
-------------------------------------
If you think this is a thing we can fix by updating the default javac output
diff set up in yetus, then yeah a yetus jira makes sense.
Personally, I'd try to fix this in our personality first by customizing how the
javac output is diffed specifically for our build. Knowing what the fix looks
like should make it more obvious if this is a problem with how we do things or
a general weakness in yetus's default plugin.
> False positive for error prone warnings in pre commit job
> ---------------------------------------------------------
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
> Reporter: Duo Zhang
> Priority: Major
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
