[ 
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802462#comment-16802462
 ] 

Duo Zhang commented on HBASE-22100:
-----------------------------------

{quote}
if we define hbase_javac_logfilter or hbase_javac_calcdiffs respectively that 
should take precedence over the ones provided by the maven plugin.
{quote}

How to do this?  I think this will be better as error prone check is just part 
of the compile and the output is like the javac warnings and errors...

> False positive for error prone warnings in pre commit job
> ---------------------------------------------------------
>
>                 Key: HBASE-22100
>                 URL: https://issues.apache.org/jira/browse/HBASE-22100
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>            Reporter: Duo Zhang
>            Priority: Major
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to