HorizonNet commented on a change in pull request #157: HBASE-16002 Made
constructors of DataType subclasses public
URL: https://github.com/apache/hbase/pull/157#discussion_r276928090
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedBlob.java
##########
@@ -32,7 +32,7 @@
public static final OrderedBlob ASCENDING = new OrderedBlob(Order.ASCENDING);
public static final OrderedBlob DESCENDING = new
OrderedBlob(Order.DESCENDING);
- protected OrderedBlob(Order order) {
+ public OrderedBlob(Order order) {
Review comment:
To make it consistent, how about making the constructors public for
consistency reasons and deprecate the static constants (and remove them in
another release) to make it more consistent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
