HorizonNet commented on a change in pull request #157: HBASE-16002 Made 
constructors of DataType subclasses public
URL: https://github.com/apache/hbase/pull/157#discussion_r277400847
 
 

 ##########
 File path: 
hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedBlob.java
 ##########
 @@ -32,7 +32,7 @@
   public static final OrderedBlob ASCENDING = new OrderedBlob(Order.ASCENDING);
   public static final OrderedBlob DESCENDING = new 
OrderedBlob(Order.DESCENDING);
 
-  protected OrderedBlob(Order order) {
+  public OrderedBlob(Order order) {
 
 Review comment:
   I think that we should discuss this on the dev list. @Apache9 Is your 
question answered? What do you think? Should we leave it as is or should we 
deprecate the static constants?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to