z-york commented on issue #209: HBASE-21070 Fix SnapshotFileCache for HBase backed by S3 URL: https://github.com/apache/hbase/pull/209#issuecomment-489197565 @Apache9 No S3 Filesystems don't support a true atomic rename (at least none that I know of :) ). I think I have changed my mind and prefer removing the modification time since I think the performance gain is marginal. I think I will remove SnapshotFileCache changes, but leave the test so we don't regress.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
