z-york commented on issue #209: HBASE-21070 Fix SnapshotFileCache for HBase backed by S3 URL: https://github.com/apache/hbase/pull/209#issuecomment-489730808 @Apache9 I took a look at the code base and do not think there is an issue with atomic rename here. The issue would be: The snapshotDir exists, but the snapshot info hasn't been copied over which will fail here: https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java#L361 which will throw. refresh cache is called by the RefreshCacheTask (which will clear on IOException), trigger refresh for testing, and getUnreferencedFiles. GetUnreferencedFiles will return no files for deletion if a corruptSnapshotException is thrown and it will be picked up the next time it is ran: https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotHFileCleaner.java#L70 So I think it is safe.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
