openinx commented on a change in pull request #268: HBASE-22491 Separate the
heap HFileBlock and offheap HFileBlock because the heap block won't need refCnt
and save into prevBlocks list before shipping
URL: https://github.com/apache/hbase/pull/268#discussion_r289340601
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
##########
@@ -523,15 +523,15 @@ void updateCurrBlockRef(HFileBlock block) {
if (block != null && curBlock != null && block.getOffset() ==
curBlock.getOffset()) {
return;
}
- if (this.curBlock != null) {
+ if (this.curBlock != null && !this.curBlock.isOnHeap()) {
prevBlocks.add(this.curBlock);
}
this.curBlock = block;
}
void reset() {
- // We don't have to keep ref to EXCLUSIVE type of block
- if (this.curBlock != null) {
+ // We don't have to keep ref to heap block
+ if (this.curBlock != null && !this.curBlock.isOnHeap()) {
Review comment:
> Adding to prevBlocks is only at these 2 places?
Yeah, check all the places, only the two add here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
