openinx commented on a change in pull request #268: HBASE-22491 Separate the
heap HFileBlock and offheap HFileBlock because the heap block won't need refCnt
and save into prevBlocks list before shipping
URL: https://github.com/apache/hbase/pull/268#discussion_r292799367
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
##########
@@ -373,7 +373,7 @@ private Cacheable asReferencedHeapBlock(Cacheable buf) {
if (buf instanceof HFileBlock) {
HFileBlock blk = ((HFileBlock) buf);
if (!blk.isOnHeap()) {
Review comment:
> At least the API name in HFileBlock we can keep like isSharedMemory()
instead of this on heap vs off heap?
Will impl this in the new patch.
> WHy we do this clone.
Because it's a offheap one, while our LRU only keep heap block, so need a
deep clone here, please see: HBASE-22127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
