[
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853096#comment-16853096
]
Sean Busbey commented on HBASE-22464:
-------------------------------------
needs update.
switching to {{--fail-never}} requires post-processing to determine if the
tests actually passed. Maven itself will always give a successful exit code.
Having the script leverage the flaky test list probably would make test runs
robust enough to not need these maven acrobatics.
Using {{mvn package}} instead of {{test}} directly will more reliably allow all
the tests to run. Our build has some funky bits that might fail even given an
{{install}} followed by a {{test}}.
IMHO it would be better if {{run_all_tests}} were optional (I don't feel
strongly on opt-in vs opt-out) generally. If you want to update things to use
{{verify}} so that we also run some of the integration tests, then I'd
definitely want some way to run the script without doing the test set.
> Improvements to hbase-vote script
> ---------------------------------
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.9, 1.3.4, 2.3.0, 2.1.4
> Reporter: Artem Ervits
> Assignee: Artem Ervits
> Priority: Trivial
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch,
> HBASE-22464.v02.patch
>
>
> This Jira proposes to add the following two improvements:
> # wget -N option for checking timestamp of downloaded RC files, if the local
> copy of downloaded file is identical on the server, that file will be ignored.
> # mvn -fn to never fail running the tests, previously with option -fae I
> could not get the whole suite to run w/out failing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
