[
https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867755#comment-16867755
]
Sean Busbey commented on HBASE-22464:
-------------------------------------
{code:java}
+ -P | additional arguments to pass to test UT/IT,
i.e. <-P runSmallTests> (runMediumTests, runLargeTests, runAllTests)
{code}
This help text should specifically say it's taking a set of maven profiles to
activate, since it doesn't allow arbitrary arguments.
Additionally, the help text above this that says we run the unit tests should
make clear that now the default is to run the small tests and folks can change
the set of tests via options below.
{code}
function run_all_tests() {
rm -f "${OUTPUT_PATH_PREFIX}"_run_all_tests
- mvn test -fae -P runAllTests -Dsurefire.rerunFailingTestsCount=3 2>&1 |
tee "${OUTPUT_PATH_PREFIX}"_run_all_tests && UNIT_TEST_PASSED=1
+ mvn package "${MVN_ARGS}" -Dsurefire.rerunFailingTestsCount=3 2>&1 | tee
"${OUTPUT_PATH_PREFIX}"_run_all_tests && UNIT_TEST_PASSED=1
}
{code}
The function name and log names are no longer accurate since we don't run all
test by default. I'd suggest changing "run_all_tests" to just "run_tests"
> Improvements to hbase-vote script
> ---------------------------------
>
> Key: HBASE-22464
> URL: https://issues.apache.org/jira/browse/HBASE-22464
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.9, 1.3.4, 2.3.0, 2.1.4
> Reporter: Artem Ervits
> Assignee: Artem Ervits
> Priority: Trivial
> Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch,
> HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch
>
>
> This Jira proposes to add the following two improvements:
> # wget -N option for checking timestamp of downloaded RC files, if the local
> copy of downloaded file is identical on the server, that file will be ignored.
> # mvn -fn to never fail running the tests, previously with option -fae I
> could not get the whole suite to run w/out failing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
