Apache9 commented on a change in pull request #287: HBASE-21512 Reimplement sync client based on async client URL: https://github.com/apache/hbase/pull/287#discussion_r291517787
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Cancellable.java ########## @@ -1,31 +0,0 @@ -/** - * - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package org.apache.hadoop.hbase.client; -import org.apache.yetus.audience.InterfaceAudience; - -/** - * This should be implemented by the Get/Scan implementations that - * talk to replica regions. When an RPC response is received from one - * of the replicas, the RPCs to the other replicas are cancelled. - */ [email protected] -interface Cancellable { - public void cancel(); - public boolean isCancelled(); -} Review comment: We have lots of tests to make sure that the feature still works. And most of behaviors are kept, the only exception is for scan. Now we will only switch replicas when opening a new scanner for a region, in the old time we may even switch replicas in the middle of a region scan, which causes the logic to be very complicated, and this does not always benefit, I'd say, ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
