Apache9 commented on a change in pull request #287: HBASE-21512 Reimplement
sync client based on async client
URL: https://github.com/apache/hbase/pull/287#discussion_r291520408
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##########
@@ -3381,7 +3364,7 @@ private void getProcedureResult(long procId,
CompletableFuture<Void> future, int
.call();
}
- private <T> ServerRequestCallerBuilder<T> newServerCaller() {
+ <T> ServerRequestCallerBuilder<T> newServerCaller() {
return this.connection.callerFactory.<T> serverRequest()
.rpcTimeout(rpcTimeoutNs, TimeUnit.NANOSECONDS)
.operationTimeout(operationTimeoutNs, TimeUnit.NANOSECONDS)
Review comment:
This patch does not introduce any incompatible changes between client and
server. And for the general question on whether hbase3 client can talk with
hbase2 cluster, I do not know... We need to test it, I think the basic
operation such as read and write could work, but the admin operations may be
broken?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
