[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865391#comment-16865391
]
Zheng Hu commented on HBASE-22561:
----------------------------------
The patch.v7 Looks good to me now. It may be better if moving the sanity
check to processFile method, and provide a flag argument , such as:
{code}
public int processFile(Path file, boolean checkRootDir) throws IOException
{code}
For the shell, use the processFile(file, false), for the JSP use the
processFile(file, true), Then we can have a ut to cover the web UI path also.
Anyway, It's good enough to commit now, just a suggestion.
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -----------------------------------------------------------------
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
> Reporter: Artem Ervits
> Assignee: Artem Ervits
> Priority: Minor
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
