[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866137#comment-16866137
]
Zheng Hu commented on HBASE-22561:
----------------------------------
For HFilePrettyPrinter, seems no need to add the -u option, also the webUI no
need the -u option ?
{code}
+ options.addOption("u", "checkRootDir", false,
+ "optional check for rootDir in case of webUI mode");
{code}
I mean, would we just call the processFile(file, falseļ¼for shell and
processFile(file, true) for webUI without adding any new command option ?
BTW, will be very gratefull if create a github PR for reviewing :-)
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -----------------------------------------------------------------
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
> Reporter: Artem Ervits
> Assignee: Artem Ervits
> Priority: Minor
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
