[ 
https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239512#comment-13239512
 ] 

Uma Maheswara Rao G commented on HBASE-5598:
--------------------------------------------

{quote}
Uma, good stuff. Please take a look at this thread from the mailing list if you 
haven't seen it yet.

http://mail-archives.apache.org/mod_mbox/hbase-dev/201203.mbox/browser
{quote}
Thanks Jon.  Yes, I have seen that discussion in mailing lists.

{quote}
I'd suggest updating the findbugs warning count in 
dev-support/test-patch.properties. Mind moving it over to HBASE-5642? We can 
keep this on as the umbrella is
{quote}

Sure, I will update the patch in HBASE-5642. But regarding updating the count, 
I am not agreeing. I am planning to use exclude filter file to exclude the 
invalid bugs. Please see the discussion in  HBASE-5597 about updating the 
count. Please correct me if i understood wrongly your question. Thanks a lot.


{quote}

You can run findbugs locally via 'mvn findbugs:findbugs'. I thought we auto 
gen'ed the file for the website – making findbugs run and generate html when 
'mvn site' 
{quote}

Alternatively you can also use 'mvn findbugs:gui'. This command will generate 
the report in UI. Updated the samplke report in this JIRA.


Thanks
Uma
                
> Analyse and fix the findbugs reporting by QA and add invalid bugs into 
> findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5598
>                 URL: https://issues.apache.org/jira/browse/HBASE-5598
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>            Priority: Minor
>         Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to 
> up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new 
> valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the 
> invalid bugs). If we find any valid ones, we can fix under this JIRA.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to