[
https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245859#comment-13245859
]
[email protected] commented on HBASE-5598:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4612/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Fixes for issues reported in findbugs for "Correctness" category.
This addresses bug HBASE-5598.
https://issues.apache.org/jira/browse/HBASE-5598
Diffs
-----
dev-support/test-patch.properties 2209d27
src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
ae76204
src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 37bcaba
src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java 32d66fb
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 64def15
src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java 1676832
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 9bd4ace
src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 3515d4a
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 8ae60a3
src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java 2694897
src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java e3b230e
src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 0c7b396
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 2e98b39
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 698bb3d
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
8950c9f
src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 62cf6ac
src/main/java/org/apache/hadoop/hbase/util/FSUtils.java aebe5b0
src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java c21377c
src/main/java/org/apache/hadoop/hbase/util/Merge.java 04f15d4
src/main/java/org/apache/hadoop/hbase/util/PoolMap.java 8e2a856
Diff: https://reviews.apache.org/r/4612/diff
Testing
-------
Ran test-patch.sh and unit tests.
Thanks,
David
> Analyse and fix the findbugs reporting by QA and add invalid bugs into
> findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to
> up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new
> valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the
> invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
