virajjasani commented on issue #333: [HBASE-22606] : BucketCache additional tests URL: https://github.com/apache/hbase/pull/333#issuecomment-505517401 > Apart from what stack mentioned, I have left few minor nits. Also what do you think of : > > * Testing unsupported IOEngines as well (i.e. other then file/files, offheap, mmap, pmem)? > * Testing more than one backing file? (using files:name1,name2 )? @jatsakthi Thanks for your review. Updated the PR addressing all comments. Please take a look. Review comments for changes suggested by @saintstack are also updated. Also, additional test for above mentioned scenarios are added: - https://github.com/apache/hbase/pull/333/files#diff-ab0037c891480f9136f0e222ba490035R337 - https://github.com/apache/hbase/pull/333/files#diff-ab0037c891480f9136f0e222ba490035R350
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
