virajjasani commented on issue #333: [HBASE-22606] : BucketCache additional 
tests
URL: https://github.com/apache/hbase/pull/333#issuecomment-506145362
 
 
   > @virajjasani usually the best way is to check if the tests are present in 
the upstream flakey list. If yes, then we can usually bypass this. Else, you 
can run the failing tests locally to check if they ought to pass. Thirdly, if 
it's almost guaranteed that the test failure is unrelated to the changes 
proposed, in that case, we can ignore the tests failures.
   
   Thanks @jatsakthi 
   Yes test failures were irrelevant in this case. Anyways, the latest build is 
successful finally.
   Could you please help me approve/merge this patch as per your latest review?
   Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to