Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-505989911 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 53 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 376 | branch-2.1 passed | | +1 | compile | 31 | branch-2.1 passed | | +1 | checkstyle | 42 | branch-2.1 passed | | +1 | shadedjars | 330 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 84 | branch-2.1 passed | | +1 | javadoc | 28 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 113 | root in the patch failed. | | +1 | compile | 30 | the patch passed | | +1 | javac | 30 | the patch passed | | -1 | checkstyle | 42 | hbase-client: The patch generated 158 new + 51 unchanged - 1 fixed = 209 total (was 52) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 171 | patch has 11 errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 105 | The patch causes 11 errors with Hadoop v2.7.7. | | -1 | hadoopcheck | 207 | The patch causes 11 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 310 | The patch causes 11 errors with Hadoop v3.0.3. | | -1 | hadoopcheck | 416 | The patch causes 11 errors with Hadoop v3.1.2. | | -1 | findbugs | 94 | hbase-client generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) | | +1 | javadoc | 27 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 32 | hbase-client in the patch failed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 1973 | | | Reason | Tests | |-------:|:------| | FindBugs | module:hbase-client | | | org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.sendMultiAction(Map, int, List, boolean) calls Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:[line 592] | | | Inconsistent synchronization of org.apache.hadoop.hbase.client.BufferedMutatorImpl.writeBufferPeriodicFlushTimer; locked 50% of time Unsynchronized access at BufferedMutatorImpl.java:50% of time Unsynchronized access at BufferedMutatorImpl.java:[line 298] | | | org.apache.hadoop.hbase.client.BufferedMutatorImpl.close() calls Thread.sleep() with a lock held At BufferedMutatorImpl.java:lock held At BufferedMutatorImpl.java:[line 251] | | | org.apache.hadoop.hbase.client.BufferedMutatorImpl.doFlush(boolean) calls Thread.sleep() with a lock held At BufferedMutatorImpl.java:lock held At BufferedMutatorImpl.java:[line 368] | | | org.apache.hadoop.hbase.client.BufferedMutatorImpl.flush() does not release lock on all paths At BufferedMutatorImpl.java:on all paths At BufferedMutatorImpl.java:[line 299] | | | Dead store to f in org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:[line 86] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 962ad3d2c112 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | branch-2.1 / a172b480fe | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/patch-mvninstall-root.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/diff-checkstyle-hbase-client.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/patch-javac-2.7.7.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/patch-javac-3.0.3.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/patch-javac-3.1.2.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/new-findbugs-hbase-client.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/patch-unit-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/testReport/ | | Max. process+thread count | 93 (vs. ulimit of 10000) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
