Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-506438174 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 26 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 218 | branch-2.1 passed | | +1 | compile | 23 | branch-2.1 passed | | +1 | checkstyle | 29 | branch-2.1 passed | | +1 | shadedjars | 222 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 60 | branch-2.1 passed | | +1 | javadoc | 21 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 222 | the patch passed | | +1 | compile | 22 | the patch passed | | +1 | javac | 22 | the patch passed | | -1 | checkstyle | 30 | hbase-client: The patch generated 18 new + 60 unchanged - 2 fixed = 78 total (was 62) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 219 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 928 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | -1 | findbugs | 73 | hbase-client generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0) | | +1 | javadoc | 23 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 116 | hbase-client in the patch failed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 2565 | | | Reason | Tests | |-------:|:------| | FindBugs | module:hbase-client | | | org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.sendMultiAction(Map, int, List, boolean) calls Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:[line 592] | | | Inconsistent synchronization of org.apache.hadoop.hbase.client.BufferedMutatorImpl.writeBufferPeriodicFlushTimer; locked 46% of time Unsynchronized access at BufferedMutatorImpl.java:46% of time Unsynchronized access at BufferedMutatorImpl.java:[line 236] | | | org.apache.hadoop.hbase.client.BufferedMutatorImpl.doFlush(boolean) calls Thread.sleep() with a lock held At BufferedMutatorImpl.java:lock held At BufferedMutatorImpl.java:[line 371] | | | org.apache.hadoop.hbase.client.BufferedMutatorImpl.flush() does not release lock on all paths At BufferedMutatorImpl.java:on all paths At BufferedMutatorImpl.java:[line 302] | | | Dead store to f in org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:[line 97] | | Failed junit tests | hadoop.hbase.client.TestBufferedMutator | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7071126567ec 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | branch-2.1 / 60097a6467 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/7/artifact/out/diff-checkstyle-hbase-client.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/7/artifact/out/new-findbugs-hbase-client.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/7/artifact/out/patch-unit-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/7/testReport/ | | Max. process+thread count | 104 (vs. ulimit of 10000) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/7/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
