HorizonNet commented on a change in pull request #345: HBASE-22638 : Checkstyle 
changes for Zookeeper Utility classes
URL: https://github.com/apache/hbase/pull/345#discussion_r298483616
 
 

 ##########
 File path: 
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
 ##########
 @@ -246,7 +246,7 @@ private static void login(Configuration conf, String 
keytabFileKey,
     private static final Map<String, String> BASIC_JAAS_OPTIONS = new 
HashMap<>();
     static {
       String jaasEnvVar = System.getenv("HBASE_JAAS_DEBUG");
-      if (jaasEnvVar != null && "true".equalsIgnoreCase(jaasEnvVar)) {
+      if ("true".equalsIgnoreCase(jaasEnvVar)) {
 
 Review comment:
   Why was the null check removed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to