virajjasani commented on a change in pull request #345: HBASE-22638 : Zookeeper
Utility enhancements
URL: https://github.com/apache/hbase/pull/345#discussion_r298791884
##########
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
##########
@@ -2135,7 +2150,7 @@ public static void logZKTree(ZKWatcher zkw, String root)
{
* @see #logZKTree(ZKWatcher, String)
* @throws KeeperException if an unexpected exception occurs
*/
- protected static void logZKTree(ZKWatcher zkw, String root, String prefix)
+ private static void logZKTree(ZKWatcher zkw, String root, String prefix)
Review comment:
This also looks like an eligible utility function to remain private as it is
being used in only this class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
