virajjasani commented on a change in pull request #345: HBASE-22638 : Zookeeper
Utility enhancements
URL: https://github.com/apache/hbase/pull/345#discussion_r298791858
##########
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
##########
@@ -1996,10 +2011,10 @@ private static void appendPeerState(ZKWatcher zkw,
String znodeToProcess, String
* @return The array of response strings.
* @throws IOException When the socket communication fails.
*/
- public static String[] getServerStats(String server, int timeout)
+ private static String[] getServerStats(String server, int timeout)
throws IOException {
String[] sp = server.split(":");
- if (sp == null || sp.length == 0) {
+ if (sp.length == 0) {
Review comment:
Right but string.split() will never return null so no need to have this check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
