wchevreuil commented on a change in pull request #3: Hbase 22567
URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r300456824
##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##########
@@ -334,6 +469,51 @@ private static final String getCommandUsage() {
writer.println(" Returns \"0\" SUCCESS code if it informed region state
is changed, "
+ "\"1\" FAIL code otherwise.");
writer.println();
+ writer.println(" " + ADD_MISSING_REGIONS_IN_META_FOR_TABLES + "
<NAMESPACE|"
+ + "NAMESPACE:TABLENAME>...");
+ writer.println(" To be used in scenarios where some regions may be
missing in META,");
+ writer.println(" but there's still a valid 'regioninfo metadata file on
HDFS. ");
+ writer.println(" This is a lighter version of 'OfflineMetaRepair tool
commonly used for ");
+ writer.println(" similar issues on 1.x release line. ");
+ writer.println(" This command needs META to be online. For each table
name passed as");
+ writer.println(" parameter, it performs a diff between regions available
in META, ");
+ writer.println(" against existing regions dirs on HDFS. Then, for region
dirs with ");
Review comment:
The most critical features I can think of here are Splits and Merges, but I
believe CatalogJanitor would move retired regions dirs to archive when it
deletes given region from meta, right? Retired regions still in meta with
region dirs wouldn't be a problem, because as long as these still have entries
on meta, it wouldn't be marked as missing. Would you think of any valid
scenario where meta doesn't have a given region, but this region dir is still
on hdfs (non archived)? If so, then I think it could be a problem because this
command would recreate this region info in meta.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
