wchevreuil commented on a change in pull request #3: Hbase 22567
URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r300464335
 
 

 ##########
 File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
 ##########
 @@ -334,6 +469,51 @@ private static final String getCommandUsage() {
     writer.println("   Returns \"0\" SUCCESS code if it informed region state 
is changed, "
       + "\"1\" FAIL code otherwise.");
     writer.println();
+    writer.println(" " + ADD_MISSING_REGIONS_IN_META_FOR_TABLES + " 
<NAMESPACE|"
+      + "NAMESPACE:TABLENAME>...");
+    writer.println("   To be used in scenarios where some regions may be 
missing in META,");
+    writer.println("   but there's still a valid 'regioninfo metadata file on 
HDFS. ");
+    writer.println("   This is a lighter version of 'OfflineMetaRepair tool 
commonly used for ");
+    writer.println("   similar issues on 1.x release line. ");
+    writer.println("   This command needs META to be online. For each table 
name passed as");
+    writer.println("   parameter, it performs a diff between regions available 
in META, ");
+    writer.println("   against existing regions dirs on HDFS. Then, for region 
dirs with ");
+    writer.println("   no matches in META, it reads regioninfo metadata file 
and ");
+    writer.println("   re-creates given region in META. Regions are re-created 
in 'CLOSED' ");
+    writer.println("   state at META table only, but not in Masters' cache, 
and are not ");
+    writer.println("   assigned either. A rolling Masters restart, followed by 
a ");
 
 Review comment:
   It's the penalty for doing things without consent from Master :)...
   
   We are performing client puts of region infos into meta. While it does 
insert the region back into meta, Active 
_Master.AssignmentManager.RegionStateStore_ never gets updated about the new 
region, so any attempt to assign these re-added regions will fail, because AM 
doesn't know these regions. I couldn't find, currently, any master rpc 
available method that could trigger a meta _reload_.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to