saintstack commented on a change in pull request #378: HBASE-22684 The log
rolling request maybe canceled immediately in Log…
URL: https://github.com/apache/hbase/pull/378#discussion_r303222738
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java
##########
@@ -100,23 +99,14 @@ public LogRoller(final Server server, final
RegionServerServices services) {
super("LogRoller");
this.server = server;
this.services = services;
- this.rollperiod = this.server.getConfiguration().
+ this.rollPeriod = this.server.getConfiguration().
getLong("hbase.regionserver.logroll.period", 3600000);
this.threadWakeFrequency = this.server.getConfiguration().
getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 * 1000);
this.checkLowReplicationInterval = this.server.getConfiguration().getLong(
"hbase.regionserver.hlog.check.lowreplication.interval", 30 * 1000);
}
- @Override
- public void interrupt() {
- // Wake up if we are waiting on rollLog. For tests.
- synchronized (rollLog) {
- this.rollLog.notify();
- }
- super.interrupt();
- }
-
Review comment:
Why this removed? We do it otherwise now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
