saintstack commented on a change in pull request #378: HBASE-22684 The log
rolling request maybe canceled immediately in Log…
URL: https://github.com/apache/hbase/pull/378#discussion_r303223654
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
##########
@@ -1128,6 +1119,11 @@ public abstract long append(RegionInfo info, WALKeyImpl
key, WALEdit edits, bool
protected abstract W createWriterInstance(Path path)
throws IOException, CommonFSUtils.StreamLacksCapabilityException;
+ /**
+ * Notice that you need to clear the {@link #rollRequested} flag in this
method, as the new writer
+ * will begin to work before returning from this method. If we clear the
flag after returning from
+ * this call, we may miss a roll request. The implementation class should
choose a proper wa
Review comment:
Comment is incomplete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
