[
https://issues.apache.org/jira/browse/HBASE-22648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885681#comment-16885681
]
HBase QA commented on HBASE-22648:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
57s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
59s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 12m
57s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
4s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 11m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 3m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
2s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
8s{color} | {color:red} The patch generated 2 new + 273 unchanged - 1 fixed =
275 total (was 274) {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green} 0m
1s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 9m
6s{color} | {color:blue} patch has no errors when building the reference guide.
See footer for rendered docs, which you should manually inspect. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
6s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 0s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
8m 25s{color} | {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 12m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m
40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}289m 38s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 3m
0s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}420m 45s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestCloneSnapshotFromClientNormal |
| | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
| | hadoop.hbase.client.TestSnapshotCloneIndependence |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.7 Server=18.09.7 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/625/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22648 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12974747/HBASE-22648-master-v4.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc
hbaseprotoc rubocop ruby_lint |
| uname | Linux ce273fbdf4d2 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25
05:29:03 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 8f56bee93b |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/625/artifact/patchprocess/branch-site/book.html
|
| findbugs | v3.1.11 |
| rubocop | v0.72.0 |
| rubocop |
https://builds.apache.org/job/PreCommit-HBASE-Build/625/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.1 |
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/625/artifact/patchprocess/patch-site/book.html
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/625/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/625/testReport/ |
| Max. process+thread count | 4773 (vs. ulimit of 10000) |
| modules | C: hbase-protocol-shaded hbase-common hbase-protocol hbase-client
hbase-server hbase-shell . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/625/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Snapshot TTL
> ------------
>
> Key: HBASE-22648
> URL: https://issues.apache.org/jira/browse/HBASE-22648
> Project: HBase
> Issue Type: New Feature
> Components: snapshots
> Affects Versions: 3.0.0
> Reporter: Andrew Purtell
> Assignee: Viraj Jasani
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-22648-master-v2.patch,
> HBASE-22648-master-v3.patch, HBASE-22648-master-v4.patch,
> HBASE-22648-master.patch, Screen Shot 2019-07-10 at 8.49.13 PM.png, Screen
> Shot 2019-07-10 at 8.52.30 PM.png, Screen Shot 2019-07-10 at 9.06.36 PM.png
>
>
> Snapshots have a lifecycle that is independent from the table from which they
> are created. Although data in a table may be stored with TTL the data files
> containing them become frozen by the snapshot. Space consumed by expired
> cells will not be reclaimed by normal table housekeeping like compaction.
> While this is expected it can be inconvenient at scale. When many snapshots
> are under management and the data in various tables is expired by TTL some
> notion of optional TTL (and optional default TTL) for snapshots could be
> useful. It will help prevent the accumulation of junk files by automatically
> dropping the snapshot after the assigned TTL, making their data files
> eligible for cleaning. More comprehensive snapshot lifecycle management may
> be considered in the future but this one case is expected to be immediately
> useful given TTls on data are commonly applied for similar convenience.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
