sunhelly commented on a change in pull request #375: HBASE-21426
TestEncryptionKeyRotation.testCFKeyRotation is flaky
URL: https://github.com/apache/hbase/pull/375#discussion_r303745811
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionKeyRotation.java
##########
@@ -91,6 +92,7 @@ public static void setUp() throws Exception {
conf.setInt("hfile.format.version", 3);
conf.set(HConstants.CRYPTO_KEYPROVIDER_CONF_KEY,
KeyProviderForTesting.class.getName());
conf.set(HConstants.CRYPTO_MASTERKEY_NAME_CONF_KEY, "hbase");
+ conf.setInt("hbase.hfile.compaction.discharger.interval", 10 * 60 * 1000);
Review comment:
@infraio Thanks for reviewing.
> Why this config change?
I changed this to let the compacted files be cleaned up slower than
normal(10min instead of 2min). Because when I run testCFKeyRotation() for 100
times, I have met assertion fail at `List<Path> compactedPaths =
findCompactedStorefilePaths(htd.getTableName());
assertTrue(compactedPaths.size() > 0);`. So this test case may also be
flaky at this assertion.
Enlarging the compaction discharger interval can ensure compacted files
still be there after major compaction is completed but compacted paths are not
checked in testCFKeyRotation().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
