sunhelly commented on a change in pull request #375: HBASE-21426
TestEncryptionKeyRotation.testCFKeyRotation is flaky
URL: https://github.com/apache/hbase/pull/375#discussion_r304202057
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionKeyRotation.java
##########
@@ -91,6 +92,7 @@ public static void setUp() throws Exception {
conf.setInt("hfile.format.version", 3);
conf.set(HConstants.CRYPTO_KEYPROVIDER_CONF_KEY,
KeyProviderForTesting.class.getName());
conf.set(HConstants.CRYPTO_MASTERKEY_NAME_CONF_KEY, "hbase");
+ conf.setInt("hbase.hfile.compaction.discharger.interval", 10 * 60 * 1000);
Review comment:
I checked the test class config, it's a MediumTests.class, which will
complete in 50 seconds. So the test method testCFKeyRotation() must complete in
50 secs, less than the cleaner interval(2 mins). I met this problem because
when I ran 100 times of the method, I used parameterized running. All 100 cases
used the same minicluster and when ran after 2 mins the case may met with
checking compacted files fail.
@infraio I will convert the change of the conf.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
