wchevreuil commented on a change in pull request #439: HBASE-22618 Provide a
way to have Heterogeneous deployment
URL: https://github.com/apache/hbase/pull/439#discussion_r310176814
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
##########
@@ -457,6 +450,13 @@ public void testLosingRs() throws Exception {
assertNull(plans);
}
Review comment:
How about test that, upon _StochasticLoadBalancer.balanceCluster()_ call,
verify that _DummyCostFunctions.cost()_ get indeed called? That would validate
custom cost functions are indeed used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
