wchevreuil commented on a change in pull request #439: HBASE-22618 Provide a 
way to have Heterogeneous deployment
URL: https://github.com/apache/hbase/pull/439#discussion_r310521806
 
 

 ##########
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
 ##########
 @@ -457,6 +450,13 @@ public void testLosingRs() throws Exception {
     assertNull(plans);
   }
 
 
 Review comment:
   Maybe we should keep this jira concerned only with the implementation to 
allow additional cost functions to be added. Then you could propose another 
jira with the real implementation of your cost functions, which then would also 
define those functions specific tests. What would you say?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to