openinx commented on a change in pull request #440: HBASE-22776 Rename config
names in user scan snapshot feature
URL: https://github.com/apache/hbase/pull/440#discussion_r310864062
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/SnapshotScannerHDFSAclHelper.java
##########
@@ -511,9 +556,16 @@ boolean isNotFamilyOrQualifierPermission(TablePermission
tablePermission) {
return !tablePermission.hasFamily() && !tablePermission.hasQualifier();
}
- boolean isTableUserScanSnapshotEnabled(TableDescriptor tableDescriptor) {
+ public static boolean isAclSyncToHdfsEnabled(Configuration conf) {
+ String masterCoprocessors =
conf.get(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY);
Review comment:
Use conf.getStrings to parse the masterCoprocessors ? and then use the
HashSet to check the existence of SnapshotScannerHDFSAclController &
AccessController ... that would be better...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
