openinx commented on a change in pull request #440: HBASE-22776 Rename config
names in user scan snapshot feature
URL: https://github.com/apache/hbase/pull/440#discussion_r310865311
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/SnapshotScannerHDFSAclController.java
##########
@@ -233,9 +234,11 @@ public void
postDeleteTable(ObserverContext<MasterCoprocessorEnvironment> ctx,
try (Table aclTable =
ctx.getEnvironment().getConnection().getTable(PermissionStorage.ACL_TABLE_NAME))
{
Set<String> users =
SnapshotScannerHDFSAclStorage.getTableUsers(aclTable, tableName);
- // 1. Delete table owner permission is synced to HDFS in acl table
+ // 1. Remove table archive directory default ACLs
+ hdfsAclHelper.removeTableDefaultAcl(tableName, users);
Review comment:
Also here , any UT to address the default acl removing ? If no , please add
some..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
