[ 
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243018#comment-13243018
 ] 

Lars Hofhansl commented on HBASE-5682:
--------------------------------------

Thanks Ted.

# the condition is different, because that is what it did before. I.e. if the 
connection is managed the trackers are setup only at construction and during 
abort in the specific case of SessionExpiredException. If the connection is 
unmanaged on the other hand the trackers are rechecked before they are needed 
and hence abort becomes a no-op for any KeeperExcepion. Hence the condition is 
exactly reversed. This part is the key of the patch actually.
# The space wasn't there before. I actually had the space added and then 
removed it again :) I'll add it back.


                
> Allow HConnectionImplementation to recover from ZK connection loss (for 0.94 
> only)
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-5682
>                 URL: https://issues.apache.org/jira/browse/HBASE-5682
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.1
>
>         Attachments: 5682-v2.txt, 5682.txt
>
>
> Just realized that without this HBASE-4805 is broken.
> I.e. there's no point keeping a persistent HConnection around if it can be 
> rendered permanently unusable if the ZK connection is lost temporarily.
> Note that this is fixed in 0.96 with HBASE-5399 (but that seems to big to 
> backport)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to